Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ejs templates to 3.x #1392

Closed
zachleat opened this issue Sep 4, 2020 · 0 comments
Closed

Upgrade ejs templates to 3.x #1392

zachleat opened this issue Sep 4, 2020 · 0 comments
Labels
breaking-change This will have to be included with a major version as it breaks backwards compatibility. enhancement template-language: ejs
Milestone
Eleventy 1.0.0

Comments

@zachleat
Copy link
Member

zachleat commented Sep 4, 2020 •
edited
Loading

Changelog https://github.com/mde/ejs/blob/main/CHANGELOG.md#v301-2019-11-23

    Removed require.extensions (@mde)
    Removed legacy preprocessor include (@mde)
    Removed support for EOL Nodes 4 and 6 (@mde)

This includes legitimate changes that broke some of our tests.

Specifically <% include /included %> style includes were removed and must be changed to <%- include('/included') -%>

Don’t forget the dash! <%- and -%>!
@zachleat zachleat added enhancement breaking-change This will have to be included with a major version as it breaks backwards compatibility. labels Sep 4, 2020
@zachleat zachleat added this to the Eleventy 1.0.0 milestone Sep 4, 2020
This was referenced Aug 16, 2021
Closed
Closed
@zachleat zachleat mentioned this issue Jun 30, 2022
Closed
cmey added a commit to cmey/lease-generator that referenced this issue Nov 15, 2022
@cmey
Upgrade ejs and update include syntax
16903e5 
Legacy syntax no longer supported: 11ty/eleventy#1392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change This will have to be included with a major version as it breaks backwards compatibility. enhancement template-language: ejs
Projects
None yet
Milestone
Eleventy 1.0.0
Development

No branches or pull requests
1 participant
@zachleat