Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPM audit (via handlebars dependency) #1026

Closed
zachleat opened this issue Mar 20, 2020 · 2 comments
Closed

NPM audit (via handlebars dependency) #1026

zachleat opened this issue Mar 20, 2020 · 2 comments
Labels
bug: dependency A problem in one of Eleventy’s dependencies npm-audit Security audits from npm
Milestone
Eleventy v0.11.0

Comments

@zachleat
Copy link
Member

At time of issue opening we are on the latest handlebars

                       === npm audit security report ===

┌──────────────────────────────────────────────────────────────────────────────┐
│                                Manual Review                                 │
│            Some vulnerabilities require your attention to resolve            │
│                                                                              │
│         Visit https://go.npm.me/audit-guide for additional guidance          │
└──────────────────────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Low           │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ minimist                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=0.2.1 <1.0.0 || >=1.2.3                                    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ handlebars                                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ handlebars > optimist > minimist                             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/1179                            │
└───────────────┴──────────────────────────────────────────────────────────────┘
@zachleat zachleat added the bug: dependency A problem in one of Eleventy’s dependencies label Mar 20, 2020
This was referenced Mar 20, 2020
Closed
Closed
@zachleat
Copy link
Member Author

Filed upstream here handlebars-lang/handlebars.js#1661 or handlebars-lang/handlebars.js#1658

@KyleMit KyleMit mentioned this issue May 4, 2020
Merged
@zachleat zachleat added this to the Eleventy v0.11.0 milestone May 10, 2020
@zachleat
Copy link
Member Author

zachleat commented May 10, 2020 •
edited
Loading

v0.10.0 is Handlebars 4.5.3
v0.11.0 is Handlebars 4.7.6 and this audit is no long present (per the above issues it was included with Handlebars 4.7.4)

@zachleat zachleat added the npm-audit Security audits from npm label May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug: dependency A problem in one of Eleventy’s dependencies npm-audit Security audits from npm
Projects
None yet
Milestone
Eleventy v0.11.0
Development

No branches or pull requests
1 participant
@zachleat