Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fatal errors in admin-ajax request following introduction of namespace. #161

Closed
1 task done
peterwilsoncc opened this issue Sep 12, 2023 · 0 comments · Fixed by #162
Closed
1 task done

Fatal errors in admin-ajax request following introduction of namespace. #161

peterwilsoncc opened this issue Sep 12, 2023 · 0 comments · Fixed by #162
Assignees
@peterwilsoncc
Labels
type:bug Something isn’t working.
Milestone
2.6.0

Comments

@peterwilsoncc
Copy link
Contributor

Describe the bug

Follow up to #153.

The introduction of a namespace is causing fatal errors due to stdClass and WP_Query being undefined.

The error only occurs in the admin ajax request.

Steps to Reproduce

  1. Go to WP Admin > Pages
  2. Open your browser's network tab in dev tools
  3. Create pages if required.
  4. Drag pages to re-order
  5. The network response is a 500.

Screenshots, screen recording, code snippet

No response

Environment information

  • Plugin version: Develop
  • WP: 6.3.1

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@peterwilsoncc peterwilsoncc added the type:bug Something isn’t working. label Sep 12, 2023
@peterwilsoncc peterwilsoncc self-assigned this Sep 12, 2023
@peterwilsoncc peterwilsoncc mentioned this issue Sep 12, 2023
Merged
4 tasks
@peterwilsoncc peterwilsoncc added this to the 2.6.0 milestone Sep 12, 2023
@peterwilsoncc peterwilsoncc moved this from Incoming to In Review in Open Source Practice Sep 12, 2023
@github-project-automation github-project-automation bot moved this from In Review to Merged in Open Source Practice Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterwilsoncc peterwilsoncc

Labels
type:bug Something isn’t working.
Projects
Open Source Practice
Archived in project
Milestone
2.6.0
Development

Successfully merging a pull request may close this issue.

Use required classes from global namespace. 10up/simple-page-ordering
1 participant
@peterwilsoncc