-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve UX for initial loading on site frontend #15
Comments
Could the plugin ship with the base skin images and render those initially until the player and correct skin and audio file(s) load in? |
I've pushed some changes that help with the front-end a bit. We change the individual audio players from having In my testing, the WebAmp player loads in fairly quickly, so while I still think it would be nice to have some sort of placeholder or loading indicator, things are better now |
@fabiankaegy any tweaks you might recommend on initial UX here? |
@jeffpaul After doing some research in admin and frontend, there are couple of items I have noted:
Note: I think all the items I mentioned should not be a problem. But, just wanted to add my experience being a new user. |
@jeffpaul this maybe already fixed as part of some other PR. While testing:
As of now, we just have a plain empty container until the player loads. We can improvise that if needed in a separate enhancement issue. @mehul0810 can you open that as a separate ticket? It will be easier to track that way. |
@Sidsector9 Thanks for reviewing. I have created the issue #83 |
It looks like we could build upon the work in Gutenberg 14.7/14.6 in adding WordPress/gutenberg#45875 && WordPress/gutenberg#45300 such that we can set the default height of the block (based upon the components enabled: player, playlist, visualizations, etc). This will likely mean we need to bump the WP minimum to 6.2 as I believe these Gutenberg updates will be in core then, so a PR to handle for this is not a near-term need but something we should aim for in testing for WP 6.2 compat later in March. |
I wasn't able to replicate any CLS or content layout replacement happening on FE. It looks like all the skins default to the same size, which is already pre-set via CSS. |
Is your enhancement related to a problem? Please describe.
From @dkotter in #6:
Describe the solution you'd like
Review the work in #6, the current state of the develop branch, and what approach should (if any) be taken to resolve this issue.
Designs
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: