Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The plugin hasn't been tested with an upcoming version of WordPress #41

Closed
github-actions bot opened this issue Oct 24, 2024 · 6 comments · Fixed by #42 or #43
Closed

The plugin hasn't been tested with an upcoming version of WordPress #41

github-actions bot opened this issue Oct 24, 2024 · 6 comments · Fixed by #42 or #43
Assignees
Labels
Milestone

Comments

@github-actions
Copy link

There is an upcoming WordPress version in the release candidate stage that the plugin hasn't been tested with. Please test it and then change the "Tested up to" field in the plugin readme.

Tested up to: 6.6
Upcoming version: 6.7

This issue will be closed automatically when the versions match.

@jeffpaul
Copy link
Member

Noting an issue I caught today in testing the live preview on dotorg, whatever sample Figma file we're using appears to may not be available (currently? permanently? uncertain).

Image

So would be good to see if that files gone and we need to use a different sample file. Also, it might be helpful in this error state for the URL that's available behind the "Edit URL" block toolbar option to be linked to somehow from that message like "Whoops! We can't seem to find that Figma file. Please check the URL." with "check the URL" linked to the "Edit URL" option?

@thrijith thrijith self-assigned this Oct 25, 2024
@thrijith thrijith moved this from Incoming to In Progress in Open Source Practice Oct 25, 2024
@thrijith thrijith mentioned this issue Oct 25, 2024
3 tasks
@thrijith
Copy link
Member

Hi @jeffpaul I've tested the plugin and was able to replicate the error with URL https://www.figma.com/file/LKQ4FJ4bTnCSjedbRpk931/Sample-Filesss in the embed block, I did check possibility of adding the edit link you mentioned but was not able to find a way for it, we do have an option to edit the url from block tool bar so it isn't a blocker right now correct?

I was able to find this URL https://www.figma.com/proto/nrPSsILSYjesyc5UHjYYa4/Embed-Kit-2.0-examples?content-scaling=fixed&kind=proto&node-id=5-3&scaling=scale-down which I used in my test locally, not sure if we want to use it in playground.

@thrijith thrijith moved this from In Progress to Code Review in Open Source Practice Oct 25, 2024
@github-project-automation github-project-automation bot moved this from Code Review to Done in Open Source Practice Oct 29, 2024
@jeffpaul
Copy link
Member

Reopening to port changes in readme.txt (WP tested-up-to and minimum) to trunk so the GH Action will deploy that to dotorg.

@jeffpaul jeffpaul reopened this Oct 29, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Open Source Practice Oct 29, 2024
Copy link
Author

github-actions bot commented Nov 4, 2024

The "Tested up to" version in the readme matches the latest version now, closing this issue.

@github-actions github-actions bot closed this as completed Nov 4, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Open Source Practice Nov 4, 2024
@jeffpaul jeffpaul reopened this Nov 4, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Open Source Practice Nov 4, 2024
Copy link
Author

github-actions bot commented Nov 5, 2024

The "Tested up to" version in the readme matches the latest version now, closing this issue.

@github-actions github-actions bot closed this as completed Nov 5, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Open Source Practice Nov 5, 2024
@jeffpaul jeffpaul reopened this Nov 5, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Open Source Practice Nov 5, 2024
@jeffpaul jeffpaul added this to the 0.4.0 milestone Nov 5, 2024
Copy link
Author

github-actions bot commented Nov 5, 2024

The "Tested up to" version in the readme matches the latest version now, closing this issue.

@github-actions github-actions bot closed this as completed Nov 5, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Open Source Practice Nov 5, 2024
@jeffpaul jeffpaul linked a pull request Nov 5, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
2 participants