Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translator comments are inconsistent #948

Closed
1 task done
peterwilsoncc opened this issue Sep 28, 2022 · 0 comments · Fixed by #949
Closed
1 task done

Translator comments are inconsistent #948

peterwilsoncc opened this issue Sep 28, 2022 · 0 comments · Fixed by #949
Assignees
Labels
type:bug Something isn't working.
Milestone

Comments

@peterwilsoncc
Copy link
Collaborator

Describe the bug

Numerous strings with placeholders either have conflicting translator comments or lack translator comments.

According to wp i18n make-pot:

Warning: The string "Distributed to %1$s connection." has 2 different translator comments. (includes/distributed-post-ui.php:93)
Warning: The string "Blog #%d" has 2 different translator comments. (includes/syndicated-post-ui.php:443)

Steps to Reproduce

  1. Check out develop branch
  2. run npm i; npm run build
  3. run wp i18n make-pot . --include="distributor.php,dist/js/*.min.js,includes,templates,assets"

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@peterwilsoncc peterwilsoncc added the type:bug Something isn't working. label Sep 28, 2022
@peterwilsoncc peterwilsoncc added this to the 2.0.0 milestone Sep 28, 2022
@peterwilsoncc peterwilsoncc self-assigned this Sep 28, 2022
@jeffpaul jeffpaul moved this from 🆕 New to ✅ Done in Distributor 2.0.0 Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant