Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomy terms don’t sync among sites. #625

Closed
manolobevia opened this issue Aug 11, 2020 · 3 comments · Fixed by #951
Closed

Taxonomy terms don’t sync among sites. #625

manolobevia opened this issue Aug 11, 2020 · 3 comments · Fixed by #951
Assignees
Labels
type:bug Something isn't working.
Milestone

Comments

@manolobevia
Copy link

Let’s say I have 2 sites (Site A and B). I create several posts with taxonomy terms on B, then in site A I pulled from B, and I am able to see the posts pulled form B with their taxonomy terms.
Then I update a post on site B with it has 3 taxonomy terms, but I decide to delete one.
Site A is synced with B, and the post is updated showing two taxonomy terms. If I add more terms on B, A is synced too. If I delete others on B, but at least I leave one term, site A is synced too. The problem is if I delete all the terms on B, site A doesn’t sync.

Is there a way to solve this situation with taxonomy terms?

@jeffpaul
Copy link
Member

jeffpaul commented Oct 8, 2020

@manolobevia I ran through some tests on this, specifically the point where this breaks for you (The problem is if I delete all the terms on B, site A doesn’t sync.) and if I remove all terms in Gutenberg or Classic Editor the changes sync as expected. However, using Quick Edit from the All Posts screen to remove all terms I do see that the terms removal does NOT sync as expected but ONLY from posts created in Gutenberg but not ones from Classic Editor.

Note that I'm going to milestone this for our 2.0 release as it aligns with some of the planned work on making push/pull operate more similarly code-wise.

@jeffpaul jeffpaul added the type:bug Something isn't working. label Oct 8, 2020
@jeffpaul jeffpaul added this to the 2.0.0 milestone Oct 8, 2020
@manolobevia
Copy link
Author

@jeffpaul thank you!!!!

@peterwilsoncc
Copy link
Collaborator

I was testing this and able to reproduce the issue when deleting all tags and updating via the REST API.

My suspicion is that it has something to do with an empty( $terms ) check but I am doing some further checking to see whether it's an issue with the plugin or the REST API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants