Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the Provider class a bit more #673

Closed
1 task done
dkotter opened this issue Jan 31, 2024 · 0 comments · Fixed by #678
Closed
1 task done

Clean up the Provider class a bit more #673

dkotter opened this issue Jan 31, 2024 · 0 comments · Fixed by #678
Assignees
Milestone

Comments

@dkotter
Copy link
Collaborator

dkotter commented Jan 31, 2024

Is your enhancement related to a problem? Please describe.

With the refactoring done in #611, we know have Features as our main piece of functionality, with each Feature being powered by one or more Providers.

While some cleanup was done on the base Provider class, I think there's still things in there that used to be functional that are no longer needed (and may no longer even be used).

For instance, thinking any reference to settings (like the get_settings method) don't need to be there any longer as settings are now handled at the Feature level.

There may be other things in there as well, so just need to do a quick scan and cleanup.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants