Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable trunk E2E tests #668

Closed
1 task done
dkotter opened this issue Jan 31, 2024 · 2 comments
Closed
1 task done

Re-enable trunk E2E tests #668

dkotter opened this issue Jan 31, 2024 · 2 comments
Assignees
Milestone

Comments

@dkotter
Copy link
Collaborator

dkotter commented Jan 31, 2024

Is your enhancement related to a problem? Please describe.

Coming out of #611, there were some failing E2E tests on trunk only. In looking at most of those, they were issues with the openDocumentSettingsSidebar command that comes from our Cypress WP Utils library. My assumption is something has changed within the Block Editor and that command needs updated to account for that change.

Since this is an upstream fix, I disabled the running of E2E tests on trunk for now. As soon as that upstream change is made though, we should open a PR to pull in those changes and re-enable the tests, fixing any other issues that we may find at that point.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dkotter dkotter added this to the 3.0.0 milestone Jan 31, 2024
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice Feb 1, 2024
@jeffpaul jeffpaul modified the milestones: 3.0.0, 3.1.0 Feb 8, 2024
@jeffpaul
Copy link
Member

jeffpaul commented Feb 8, 2024

Note that I'm moving this out of the v3 milestone assuming that if WP 6.4 and 6.2 (ClassifAI's current max and min WP versions) are passing for e2e tests, then that's the important bits for a v3 release. WP 6.5 isn't due out for almost 2 months, so we've got a bit more time to sort out why WP trunk is failing on e2e tests and get that fixed but I don't think we need to block the v3 release in resolving that.

@dkotter
Copy link
Collaborator Author

dkotter commented Apr 4, 2024

This is done in 04deade so closing this out

@dkotter dkotter closed this as completed Apr 4, 2024
@github-project-automation github-project-automation bot moved this from To Do to Merged in Open Source Practice Apr 4, 2024
@dkotter dkotter removed this from the 3.1.0 milestone Apr 4, 2024
@jeffpaul jeffpaul added this to the 3.1.0 milestone Apr 17, 2024
@jeffpaul jeffpaul moved this from Merged to Done in Open Source Practice Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants