-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CustomBlockAppender. #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two minor comments but I'm excited about this one and the code looks good to me 👍
README.md
Outdated
<InnerBlocks | ||
renderAppender={() => ( | ||
<CustomBlockAppender | ||
className="accordion-item-appender" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we namescope our classes so they don't interfere with anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabiankaegy that's probably a good idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabiankaegy @tlovett1 I have updated.
Co-authored-by: Fabian Kägy <[email protected]>
@ryanwelcher were you able to address the feedback? |
…onents into feature/custom-appenders
Add the CustomBlockAppender component.
CustomBlockInserter
This component is passed to an
InnerBlocks
instance to as it'srenderAppender
to provide a customized button that opens the Block Inserter.Usage
Props
rootClientId
string
''
buttonText
string
''
icon
string
'plus'
..buttonProps
object
null'