Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: respect isEditable context in PostMeta component #344

Merged

Conversation

fabiankaegy
Copy link
Member

Description of the Change

Respect the isEditable context that one can define on the <PostContext> component inside the PostMeta component.

This is to ensure that the meta value isn't editable when editing should be disabled.

Closes #

How to test the Change

Changelog Entry

Fixed - Respect isEditable context in PostMeta component

Credits

Props @fabiankaegy

Copy link

Size Change: +154 B (+0.24%)

Total Size: 63.9 kB

Filename Size Change
dist/index.js 63.9 kB +154 B (+0.24%)

compressed-size-action

Copy link

🎉 A new testing version of this package has been published to NPM. You can install it with npm install @10up/block-components@testing-344

Copy link

cypress bot commented Oct 11, 2024

10up Block Components    Run #934

Run Properties:  status check failed Failed #934  •  git commit e5a46ed281: fix respect isEditable context in PostMeta component
Project 10up Block Components
Run status status check failed Failed #934
Run duration 06m 46s
Commit git commit e5a46ed281: fix respect isEditable context in PostMeta component
Committer Fabian Kägy
View all properties for this run ↗︎

Test results
Tests that failed  Failures 31
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5

Tests for review

Failed  ColorSettings.spec.js • 5 failed tests

View Output

Test Artifacts
ColorSettings > Allows the user to pick the block and displays it Test Replay Screenshots
ColorSettings > Allows the user to use a custom color and displays it Test Replay Screenshots
ColorSettings > Allows the user to clear the color Test Replay Screenshots
ColorSettings > Allows the user to add custom label and help text Test Replay Screenshots
ColorSettings > Allows the user to pick from predefined colors Test Replay Screenshots
Failed  Counter.spec.js • 6 failed tests

View Output

Test Artifacts
Counter > Allows the user to pick the block and displays it Test Replay Screenshots
Counter > Has the counter component in the block Test Replay Screenshots
Counter > Has the correct starting value Test Replay Screenshots
Counter > Updates the count appropriately Test Replay Screenshots
Counter > Updates to the approaching limit state appropriately Test Replay Screenshots
Counter > Updates to the is over limit state appropriately Test Replay Screenshots
Failed  IconPicker.spec.js • 1 failed test

View Output

Test Artifacts
IconPicker > allows the user to use the post picker to change an icon and displays it Test Replay Screenshots
Failed  PostFeaturedImage.spec.js • 3 failed tests

View Output

Test Artifacts
PostFeaturedImage > Allows the user to pick the block and displays it Test Replay Screenshots
PostFeaturedImage > Allows the user to pick an image from the media library and displays it inline Test Replay Screenshots
PostFeaturedImage > Syncs with the post featured image Test Replay Screenshots
Failed  PostMeta.spec.js • 6 failed tests

View Output

Test Artifacts
Post Meta > Allows the user to pick the block and displays it Test Replay Screenshots
Post Meta > Allows the user to pick a variation Test Replay Screenshots
Post Meta > Allows text to be entered into the post meta field Test Replay Screenshots
Post Meta > Allows a number to be entered into the post meta field Test Replay Screenshots
Post Meta > Allows a boolean to change the post meta field Test Replay Screenshots
Post Meta > Saves the data into post meta Test Replay Screenshots

The first 5 failed specs are shown, see all 7 specs in Cypress Cloud.

@fabiankaegy fabiankaegy merged commit eab8e78 into develop Nov 20, 2024
6 of 8 checks passed
@fabiankaegy fabiankaegy deleted the fix/respect-is-editable-context-in-post-meta-component branch November 20, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant