Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Content picker check whether item.subtype is truthy before using it #337

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

fabiankaegy
Copy link
Member

Description of the Change

The ContentPicker can be used to fetch items of different types. Taxonomy Terms for example. These don't have a subtype property defined. But unlike the code assumed the actual subtype key is sometimes present but the value is undefined. This case is now also handled.

Closes #335

How to test the Change

Changelog Entry

Fixed - Don't delete picked items if the subtype is not set

@fabiankaegy fabiankaegy self-assigned this Jul 4, 2024
@fabiankaegy fabiankaegy merged commit 45c89d7 into develop Jul 4, 2024
6 of 7 checks passed
@fabiankaegy fabiankaegy deleted the fix/content-picker-for-terms branch July 4, 2024 11:50
Copy link

github-actions bot commented Jul 4, 2024

Size Change: +11 B (+0.02%)

Total Size: 63.5 kB

Filename Size Change
dist/index.js 63.5 kB +11 B (+0.02%)

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContentPicker sometimes doesn't display all saved items
1 participant