Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow passing custom labels to MediaToolbar component #334

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

Firestorm980
Copy link
Contributor

@Firestorm980 Firestorm980 commented Jun 25, 2024

Description of the Change

Closes #242

How to test the Change

  1. Check out this branch locally
  2. Run the WP environment
  3. Add / edit a post
  4. Add the 'custom media toolbar' block
  5. Confirm updated labels

Changelog Entry

Added - Support for custom labels in MediaToolbar
Fixed - Typo in documentation
Added - Custom media toolbar example

Credits

@Firestorm980

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Copy link

github-actions bot commented Jun 25, 2024

Size Change: +76 B (+0.12%)

Total Size: 63.5 kB

Filename Size Change
dist/index.js 63.5 kB +76 B (+0.12%)

compressed-size-action

Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this enhancement :)

Left one suggestion for how we can improve the solution. With that implemented this is ready to merge from my perspective :)

components/media-toolbar/index.tsx Outdated Show resolved Hide resolved
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good :)

@fabiankaegy fabiankaegy marked this pull request as ready for review June 25, 2024 14:54
Copy link

cypress bot commented Jun 25, 2024

1 failed test on run #901 ↗︎

1 5 0 0 Flakiness 0

Details:

Fix for default labels
Project: 10up Block Components Commit: aa6e14174c
Status: Failed Duration: 01:20 💡
Started: Jun 25, 2024 3:19 PM Ended: Jun 25, 2024 3:20 PM
Failed  cypress/e2e/IconPicker.spec.js • 1 failed test

View Output

Test Artifacts
IconPicker > allows the user to use the post picker to change an icon and displays it Test Replay Screenshots

Review all test suite changes for PR #334 ↗︎

@fabiankaegy fabiankaegy changed the title Feature/mediatoolbar custom labels Featuremediatoolbar custom labels Jun 25, 2024
@fabiankaegy fabiankaegy changed the title Featuremediatoolbar custom labels Feature: Allow passing custom labels to MediaToolbar component Jun 25, 2024
@fabiankaegy
Copy link
Member

The failing test is unrelated.

Copy link

🎉 A new testing version of this package has been published to NPM. You can install it with npm install @10up/block-components@testing-334

@fabiankaegy fabiankaegy merged commit 7a6a6ea into develop Jun 25, 2024
6 of 8 checks passed
@fabiankaegy fabiankaegy deleted the feature/mediatoolbar-custom-labels branch June 25, 2024 16:51
@cypress cypress bot mentioned this pull request Jun 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MediaToolbar component: Allow configuring labels
2 participants