Migrate ContentSearch component to TS
#325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Souptik Datta <[email protected]>
Souptik2001
commented
May 15, 2024
| const ContentSearch = ({ | ||
| onSelectItem, | ||
| placeholder, | ||
| interface QueryCache { |
There was a problem hiding this comment.
There are many interfaces created for this component, therefore should it be better to move all the interfaces to another file say definitions.ts, and just import from there?
Souptik2001
commented
May 15, 2024
| /> | ||
|
|
||
| {hasSearchString || hasInitialResults ? ( | ||
| <> | ||
| <List className={`${NAMESPACE}-list`}> | ||
| {isLoading && currentPage === 1 && <StyledSpinner />} | ||
| {isLoading && currentPage === 1 && <StyledSpinner onPointerEnterCapture={null} onPointerLeaveCapture={null} />} |
There was a problem hiding this comment.
Weirdly we have to pass these two props to Spinner (specifically to SVG-based component), to stop Typescript from complaining. Otherwise, Typescript throws an error.
There is a open issue for this on the Gutenberg repo - WordPress/gutenberg#61322
But the issue is setting these props throws warning in the console now by SVG element -
Signed-off-by: Souptik Datta <[email protected]>
Signed-off-by: Souptik Datta <[email protected]>
fabiankaegy
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Migrate the
ContentSearchcomponent to TS.Found two bugs in the component, which are also fixed by this PR (Please let me know if any of these are expected feature and not a bug) -
subtype.onBlurevent attached to the search bar, which hides the initial results whenever it's triggered. And when we try to click on any of those outside options, it just blurs out and the options just vanishes.Both the bugs are demonstrated in the below video -
Screen.Recording.2024-05-16.at.1.15.27.AM.mov
Related issue - #295 and #314
How to test the Change
Checklist: