Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use unknown instead of any for unknown additional props #324

Merged
merged 1 commit into from
May 16, 2024

Conversation

fabiankaegy
Copy link
Member

Description of the Change

As called out by @Antonio-Laguna in a few CR's we should use unknown instead of any for unknown additional properties we type.

Copy link

Size Change: 0 B

Total Size: 65.1 kB

ℹ️ View Unchanged
Filename Size
dist/index.js 65.1 kB

compressed-size-action

Copy link

cypress bot commented May 15, 2024

Passing run #844 ↗︎

0 6 0 0 Flakiness 0

Details:

fix use unknown instead of any for unknown additional props
Project: 10up Block Components Commit: 047208af2d
Status: Passed Duration: 01:21 💡
Started: May 15, 2024 10:18 AM Ended: May 15, 2024 10:20 AM

Review all test suite changes for PR #324 ↗︎

@fabiankaegy fabiankaegy merged commit 0eb1bf5 into develop May 16, 2024
7 of 8 checks passed
@fabiankaegy fabiankaegy deleted the fix/type-of-unknown-attributes branch May 16, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant