Migrate Counter component to TS
#322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Souptik Datta <[email protected]>
Signed-off-by: Souptik Datta <[email protected]>
Signed-off-by: Souptik Datta <[email protected]>
Signed-off-by: Souptik Datta <[email protected]>
Souptik2001
commented
May 14, 2024
Signed-off-by: Souptik Datta <[email protected]>
Signed-off-by: Souptik Datta <[email protected]>
There was a problem hiding this comment.
@Souptik2001 you're killing it! Thanks a lot for your contribution! Love the README and the carefulness with the types! Nice job!
I left a minor comment but this LGTM!
Signed-off-by: Souptik Datta <[email protected]>
fabiankaegy
reviewed
May 14, 2024
fabiankaegy
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Migrate the
Countercomponent to TS.It also migrates
StyledComponentContextto TS as it was related to this and not separately listed in the issue.Also added a
readme.mdfile for this component, that was missing.Related issue - #295
How to test the Change
Screen.Recording.2024-05-14.at.3.47.27.PM.mov
Checklist: