Migrate ColorSetting component to TS
#320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Souptik Datta <[email protected]>
Signed-off-by: Souptik Datta <[email protected]>
There was a problem hiding this comment.
@Souptik2001 nice work! Love the example too!
This is looking good to me. There are a couple of minor issues with indentation and I left a question. Pinging @fabiankaegy for extra pair of eyes!
Signed-off-by: Souptik Datta <[email protected]>
|
Thanks @Antonio-Laguna! Addressed the issues and added my thoughts on your suggestion. 👍 |
Signed-off-by: Souptik Datta <[email protected]>
Antonio-Laguna
approved these changes
May 13, 2024
There was a problem hiding this comment.
Awesome work @Souptik2001 !
Thanks a lot for your contribution and your quick turnaround on my review suggestions!
fabiankaegy
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Migrate the
ColorSettingcomponent to TS.Related issue - #295 and also #314
How to test the Change
Checklist: