Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: styling of search results in ContentSearch component #312

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

fabiankaegy
Copy link
Member

What

Fix the visual appearance of how the Search Results of the Content Search component get rendered.

Before After
CleanShot 2024-04-16 at 08 13 00@2x CleanShot 2024-04-16 at 08 09 27@2x

Why

Because they were currently broken in WordPress 6.5

How

By adding align-items: start; to the flex container so that the items are aligned to the start of the container.

Copy link

cypress bot commented Apr 16, 2024

1 failed test on run #801 ↗︎

1 5 0 0 Flakiness 0

Details:

fix styling of search results in ContentSearch component
Project: 10up Block Components Commit: 434edbe427
Status: Failed Duration: 01:28 💡
Started: Apr 16, 2024 6:12 AM Ended: Apr 16, 2024 6:14 AM
Failed  cypress/e2e/Repeater.spec.js • 1 failed test

View Output

Test Artifacts
Repeater > Adding Repeater field and saving it. Test Replay Screenshots

Review all test suite changes for PR #312 ↗︎

Copy link

🎉 A new testing version of this package has been published to NPM. You can install it with npm install @10up/block-components@testing-312

Copy link

Size Change: +85 B (0%)

Total Size: 65.7 kB

Filename Size Change
dist/index.js 65.7 kB +85 B (0%)

compressed-size-action

@fabiankaegy fabiankaegy merged commit 04c49b2 into develop Apr 16, 2024
6 of 8 checks passed
@fabiankaegy fabiankaegy deleted the fix/styling-of-search-item branch April 16, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant