Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upkeep: Add TS support for PostTitle component #301

Merged
merged 13 commits into from
May 3, 2024
Merged

upkeep: Add TS support for PostTitle component #301

merged 13 commits into from
May 3, 2024

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Mar 3, 2024 •
edited
Loading

Description of the Change

Closes #

Screenshot

Marks invalid attributes:

Screenshot 2024-03-04 at 11 29 40 AM

How to test the Change

Changelog Entry

Changed - Add TS support for PostTitle component.

Credits

Props @fabiankaegy @Sidsector9

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@cypress Cypress
Copy link

cypress bot commented Mar 3, 2024 •
edited
Loading

1 failed test on run #818 ↗︎

1 5 0 0 Flakiness 0

Details:

Merge branch 'develop' into upkeep/component-post-title
Project: 10up Block Components Commit: 657c4f7907
Status: Failed Duration: 01:52 💡
Started: May 3, 2024 8:54 AM Ended: May 3, 2024 8:56 AM
Failed  cypress/e2e/Repeater.spec.js • 1 failed test

View Output

Test Artifacts
Repeater > Adding Repeater field and saving it. Test Replay Screenshots

Review all test suite changes for PR #301 ↗︎

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2024 •
edited
Loading

Size Change: -33 B (0%)

Total Size: 65.6 kB

Filename Size Change
dist/index.js 65.6 kB -33 B (0%)

compressed-size-action

@Sidsector9 Sidsector9 self-assigned this Mar 3, 2024
@Sidsector9 Sidsector9 force-pushed the upkeep/component-post-title branch from e903d32 to 8ab4cf5 Compare March 4, 2024 05:11
@Sidsector9 Sidsector9 changed the title upkeep: Add TS support for PostTitle component [WIP] upkeep: Add TS support for PostTitle component Mar 4, 2024
@Sidsector9 Sidsector9 changed the title [WIP] upkeep: Add TS support for PostTitle component upkeep: Add TS support for PostTitle component Mar 4, 2024
fabiankaegy
fabiankaegy reviewed Mar 4, 2024
View reviewed changes
components/post-title/index.tsx Outdated Show resolved Hide resolved
components/post-title/index.tsx Outdated Show resolved Hide resolved
@Sidsector9 Sidsector9 marked this pull request as draft March 11, 2024 16:23
@Sidsector9 Sidsector9 marked this pull request as ready for review April 1, 2024 18:27
@Sidsector9 Sidsector9 requested a review from fabiankaegy April 1, 2024 18:48
@fabiankaegy fabiankaegy merged commit 8e5c592 into develop May 3, 2024
4 of 6 checks passed
@fabiankaegy fabiankaegy deleted the upkeep/component-post-title branch May 3, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiankaegy fabiankaegy fabiankaegy left review comments

Assignees

@Sidsector9 Sidsector9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sidsector9 @fabiankaegy