upkeep: Add TS support for IsAdmin component
#299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #756 ↗︎
Details:
Review all test suite changes for PR #299 ↗︎ |
|||||||||||||||
|
Size Change: 0 B Total Size: 65.7 kB ℹ️ View Unchanged
|
fabiankaegy
reviewed
Mar 1, 2024
components/is-admin/index.ts
Outdated
Comment on lines
15
to
18
| * @param {object} props react props | ||
| * @param {*} props.fallback fallback component | ||
| * @param {*} props.children child components | ||
| * @returns {*} | ||
| * @param {React.ReactNode|null} props.fallback fallback component | ||
| * @param {React.ReactNode} props.children child components | ||
| * @returns {null|React.ReactNode} |
There was a problem hiding this comment.
When we are adding types I think we can safely remove the JSDoc comments.
If we want to add additional context to the type we can add a comment above the type value like so:
interface IsAdminProps {
/**
* fallback component
*/
fallback: React.ReactNode | null;
/**
* child component
*/
children: React.ReactNode;
}
Sidsector9
changed the title
IsAdmin componentIsAdmin component
fabiankaegy
reviewed
Mar 1, 2024
components/is-admin/index.ts
Outdated
| export const IsAdmin: React.FC<IsAdminProps> = ({ | ||
| fallback = null, | ||
| children, | ||
| }): null | React.ReactNode => { |
There was a problem hiding this comment.
I still think we can leave the return type off here
Sidsector9
force-pushed
the
upkeep/component-is-admin
branch
from
0087886 to
d69a242
Compare
Sidsector9
force-pushed
the
upkeep/component-is-admin
branch
from
d69a242 to
d84d2a1
Compare
fabiankaegy
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Closes #
How to test the Change
Changelog Entry
Credits
Props @fabiankaegy @Sidsector9
Checklist: