fix(icon picker): fix for missing icons in the editor icon picker #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarshall511
had a problem deploying
to
testing
GitHub Actions
Failure
|
Size Change: 0 B Total Size: 65.5 kB ℹ️ View Unchanged
|
|
🎉 A new testing version of this package has been published to NPM. You can install it with |
fabiankaegy
approved these changes
Jan 29, 2024
4 failed tests on run #703 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Image > allows the user to pick an image from the media library and displays it inline |
Screenshots
Video
|
|
Link.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Link > allows the editor to pick a link directly inline |
Screenshots
Video
|
|
Repeater.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Repeater > Adding Repeater field and saving it. |
Screenshots
Video
|
|
registerBlockExtension.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| registerBlockExtension > ensure the new settings still respect custom classnames |
Screenshots
Video
|
|
Review all test suite changes for PR #275 ↗︎
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixes missing icons in Safari.
Closes #274
How to test the Change
View the Icon Picker component in Safari using the editor. Verify the icons appear.
Changelog Entry
Credits
Props @bmarshall511
Checklist: