Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only output icon if one is set #189

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Only output icon if one is set #189

merged 1 commit into from
Jan 17, 2023

Conversation

tlovett1
Copy link
Member

Description of the Change

In UI Kit, we were just getting a spinner in the icon toolbar dropdown when none was set. This fixes that problem.

How to test the Change

Confirm if no icon is set, there is no spinner in the toolbar.

Changelog Entry

  • Don't output icon if none is set in toolbar

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

fabiankaegy
fabiankaegy approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@fabiankaegy fabiankaegy merged commit 3c7551e into develop Jan 17, 2023
@fabiankaegy fabiankaegy deleted the no-icon-fix branch January 17, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiankaegy fabiankaegy fabiankaegy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tlovett1 @fabiankaegy