Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Counter to a separate component #158

Merged
merged 4 commits into from
Dec 15, 2022
Merged

Move Counter to a separate component #158

merged 4 commits into from
Dec 15, 2022

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Oct 16, 2022

Note

  • We need the modified green counter SVG with the tick added in it.

Description of the Change

  • This PR moves the Counter and Circular Progress Bar to a separate component.
  • Adds a black fill to the exclamation mark of the warning icon.
  • Adds red color to icon when text goes beyond limit.

WordPress Colors are used for reference.

Closes #156

Screenshot

Screenshot 2022-10-16 at 1 18 42 PM

Screenshot 2022-10-16 at 1 19 52 PM

Screenshot 2022-10-16 at 1 22 12 PM

Changelog Entry

Changed: yellow color of the warning icon
Changed: fill of the exclamation to black color
Changed: icon color to red when text goes beyond limit

Credits

Props @Firestorm980 @Sidsector9

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul
Copy link
Member

@cadic FYI that this will likely be helpful to you on the related OSS project you're looking into

Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great :) I only left one comment about the example code.

Otherwise this is ready to go 🚀

example/src/blocks/rich-text-character-limit/index.js Outdated Show resolved Hide resolved
@fabiankaegy fabiankaegy changed the title enhancement/156: move counter to a separate component Move Counter to a separate component Dec 15, 2022
@fabiankaegy fabiankaegy added the [Type] Enhancement New feature or request label Dec 15, 2022
@fabiankaegy fabiankaegy merged commit 76d5ecc into develop Dec 15, 2022
@fabiankaegy fabiankaegy deleted the enhancement/156 branch December 15, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Counter: Spin off into individual component, a11y, and icon
3 participants