Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass contentTypes from ContentPicker to ContentSearch #13

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

johnwatkins0
Copy link
Member

Description of the Change

Fixes #12 by passing the missing prop.

Alternate Designs

Benefits

Can restrict the content picker to CPTs.

Possible Drawbacks

Verification Process

  1. Check out this branch.
  2. Create a ContentPicker with contentTypes set to a CPT.
  3. Verify that the CPT is searched instead of the default post types.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#12

Changelog Entry

Bugfix: pass missing contentTypes prop from ContentSearch from ContentPicker.

@johnwatkins0 johnwatkins0 self-assigned this Feb 23, 2021
@tlovett1 tlovett1 merged commit c42de2f into trunk Feb 24, 2021
@tlovett1 tlovett1 deleted the fix/content-type-prop branch February 24, 2021 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contentTypes not passed from ContentPicker to ContentSearch
2 participants