Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to "encrypted secrets" GitHub Docs #19

Closed
felipeelia opened this issue Dec 11, 2019 · 4 comments · Fixed by #20
Closed

Link to "encrypted secrets" GitHub Docs #19

felipeelia opened this issue Dec 11, 2019 · 4 comments · Fixed by #20
Assignees
Labels
type:bug Something isn't working.
Milestone

Comments

@felipeelia
Copy link
Member

Describe the bug

Probably GitHub has updated their docs and the Secrets are set in your repository settings link present on the README.md file points to the wrong page.

Steps to Reproduce

  1. Go to repo's README.md
  2. Click on Secrets are set in your repository settings.
  3. The link points to the Virtual environments for GitHub-hosted runners page but the related section isn't there anymore :(

Expected behavior

The link should point to this new page.

@felipeelia felipeelia added the type:bug Something isn't working. label Dec 11, 2019
@jeffpaul jeffpaul added this to the 1.5.0 milestone Dec 11, 2019
@jeffpaul
Copy link
Member

Welcome to our GitHub Actions and thanks for the report @felipeelia! Mind making the same update to the https://github.com/10up/action-wordpress-plugin-asset-update repo as well?

@felipeelia
Copy link
Member Author

Thank you @jeffpaul! I'm happy to (modestly) retribute the effort you folks put on it. I've opened a PR with the same fix there as well. Let me know if there is something else where I can help, ok?

@jeffpaul
Copy link
Member

@felipeelia there's some "help wanted"+"good first issues" scattered across 10up's repos, but if there's one of our projects or a type of work you're most comfortable with I'd be happy to dig some more specific items up... just let me know!

@felipeelia
Copy link
Member Author

I'll give a look, for sure! Thanks once more @jeffpaul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants