Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalinks in multiple configurations #75

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Permalinks in multiple configurations #75

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
584ae5a
Permalinks in multiple configurations
cadic Feb 22, 2022
943207e
Updated title of permalinks section, removed WordPress core reference
cadic Feb 24, 2022
b5f3867
Typos in _includes/markdown/Testing.md
cadic Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions _includes/markdown/Testing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ cy.visit( `/wp-admin` );

The purpose of E2E testing is to ensure the user-facing features work as expected. In the WordPress context, we can extend that purpose to "working as expected against supported WP versions and plugins/themes". At 10up, we're using GitHub Actions matrix and `wp-env` config override to solve that problem by [generating `wp-env` config](https://github.com/10up/simple-podcasting/blob/develop/tests/bin/set-core-version.js) for [each matrix](https://github.com/10up/simple-podcasting/blob/develop/.github/workflows/test-branch.yml#L30-L31). We're doing it for WP core version only, but it can be adapted and updated to handle more complex configurations.

### Permalinks in multiple configurations
### Fixing permalinks issue

When testing against non-default (latest) WordPress core, there is [known issue with file permissions](https://github.com/WordPress/gutenberg/issues/28201). This prevents us to use permalinks in testing because `.htaccess` file could not be created in GitHub Actions environment. File permissions could be fixed with [`npm run wp-env run tests-wordpress "chmod -c ugo+w /var/www/html"`](https://github.com/10up/ads-txt/pull/84/files) during the initialization.
There is [known issue with file permissions](https://github.com/WordPress/gutenberg/issues/28201). This prevents us to use permalinks in testing because `.htaccess` file could not be created in GitHub Actions environment. File permissions could be fixed with [`npm run wp-env run tests-wordpress "chmod -c ugo+w /var/www/html"`](https://github.com/10up/ads-txt/pull/84/files) during the initialization.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cadic Actually, I think the previous description is more correct.

WordPress/gutenberg#28201 isn't really related to the current issue because it doesn't mention non-default WordPress versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dinhtungdu in my previous comment a link to RSA Actions log describes that default WordPress core is affected too.

cadic marked this conversation as resolved.
Show resolved Hide resolved

### Debugging Cypress on GitHub Actions

Expand Down