-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: transform file extension for .ts
and .tsx
assets inside block.json
files
#415
Conversation
🦋 Changeset detectedLatest commit: 95aeb0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
.ts
and .tsx
assets inside block.json
files
…p/10up-toolkit into fix/support-ts-imports-in-block-json
# Conflicts: # packages/toolkit/utils/index.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. I don't see this takes care of the actual compilation process? It'd be good to have one block example on the project to demonstrate the full flow otherwise!
@Antonio-Laguna any So this fix here really is only to make sure we also rename the entry after assets are already transpiled :) |
@fabiankaegy been a while since I've gone through this!! Thanks! |
Related Issue/RFC: #414
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Checklist: