Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: watch close #401

Merged
merged 5 commits into from
Jun 4, 2024
Merged

fix: watch close #401

merged 5 commits into from
Jun 4, 2024

Conversation

nicholasio
Copy link
Member

Related Issue/RFC: #400

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.
  • I have added a changeset to my PR. See CONTRIBUTING document for instructions

@nicholasio nicholasio requested a review from fabiankaegy May 29, 2024 12:37
Copy link

changeset-bot bot commented May 29, 2024

🦋 Changeset detected

Latest commit: 886055d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
10up-toolkit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

fabiankaegy
fabiankaegy previously approved these changes May 29, 2024
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is testing well for me 👍

@nicholasio nicholasio merged commit dcc09bb into develop Jun 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants