Project command #387
Project command #387
Conversation
🦋 Changeset detectedLatest commit: 0edf924 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| setEnvVariables(variables); | ||
|
|
||
| if (fs.existsSync(variables.build_script_path)) { | ||
| execSync(`. ${__dirname}/bash/build-setup.sh; . ${variables.build_script_path}`, { |
Check warning
Code scanning / CodeQL
Shell command built from environment values Medium
|
|
||
| const initScript = `${__dirname}/bash/init.sh`; | ||
|
|
||
| execSync(`sh ${initScript}`, { stdio: 'inherit' }); |
Check warning
Code scanning / CodeQL
Shell command built from environment values Medium
| ref: trunk | ||
| file: /main.yml | ||
|
|
||
| setup_10up_toolkit: |
There was a problem hiding this comment.
Instead of cloning 10up-toolking and installing it from scratch why not use npx 10up-toolkit project init. npx will use by default the latest version in npm.
There was a problem hiding this comment.
Of course we'd need to release it first to be able to test this.
There was a problem hiding this comment.
100%. This will be removed once we release. Chicken and egg problem
| build_plugins_and_themes: | ||
| stage: build | ||
| script: | ||
| - ./10up-toolkit project create-payload $CI_COMMIT_REF_NAME |
There was a problem hiding this comment.
npx --yes 10up-toolkit project create-payload $CI_COMMIT_REF_NAME would make the previous stage to set up toolkit unnecessary as long as node is avaliable on the container.
No description provided.