Toolkit v6 - Roadmap & Breaking discussion

[Antonio-Laguna]

Given we don't encourage Browsersync anymore but was kept for backwards compatibility I'm wondering if we should use upcoming 5.0.0 as an occasion to actually remove this option and get the package leaner itself.

If so, is there anything else we could consider to introduce that's breaking?

I wonder this since we want to be stable and don't break but there are instances in which we need to so let's use those to remove legacy and discouraged processes.

Maybe we should enforce useBlocks now?

Thoughts @nicholasio & @fabiankaegy

UPDATE with list of breaking changes and rollout tasks

Breaking Changes

• useBlockAssets on by default #325
• Upgrade stylelint-config to use stylelint v15 #284
• Update postcss-preset-env to v9 #326
• Remove browser-sync support #327

Other Changes

• Enable Sourcemaps on production #302
• Stop using react-refresh-webpack plugin fork #323
• postcss-editor-styles: Move to antonio's fork

Rollout Plan

• [Internal] Blog Post announcing upcoming breaking changes.
• Release v6 in the next branch and ask for testers

[nicholasio]

I agree it's about time to remove browser sync.

Regarding useBlocks I think we can make it the default option in 5.0 but still give the option to preserve the current default behavior.

[Antonio-Laguna]

@fabiankaegy do you think we could get rid of this too?

https://github.com/10up/10up-toolkit/blob/develop/packages/toolkit/config/postcss.config.js#L18

[fabiankaegy]

Thanks for starting this discussion :)

And yeah I think it is time to make the useBlockAssets feature flag the default behavior. But I will add that I have only ever used toolkit for WordPress related projects. And whilst I don't think that it would have any effect on anything outside of that we should make sure that it was tested with such projects.

@fabiankaegy do you think we could get rid of this too?

https://github.com/10up/10up-toolkit/blob/develop/packages/toolkit/config/postcss.config.js#L18

Yeah I'd love to remove this handling and even the need for the editor styles scoping post CSS plugin altogether

[nicholasio]

Also wanted to bring this to the table #297

[nicholasio]

Updated issue description with breaking changes for next major and rolloup plan