Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] Initial Dockerfile to host pix-site in scaleway #652

Merged
merged 7 commits into from
May 17, 2024

Conversation

alipix
Copy link
Contributor

@alipix alipix commented May 3, 2024

🦄 Problème

Les applications de ce repo ne sont pas déployable sur un autre hébergeur utilisant des images docker

🤖 Proposition

Ajouter un Dockerfile générique qui nous permet de build les 2 sites en image Docker.

🌈 Remarques

La configuration ne fonctionne pas totalement en local si on utilise un port custom (ex localhost:8080)

On a modifié la configuration Nginx pour utiliser les templates nginx de Docker pour rendre cette configuration plus propre.

💯 Pour tester

docker build --build-arg SITE=pix-site -t pix-image . 

docker run -ti -p 8080:80 pix-site 

CI en vert > Validation que Scalingo fonctionne toujours

@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-site-review-pr652/environment

@BerengereC
Copy link
Contributor

Les logs d'accès étaient visibles avant sur scalingo et ne le sont plus :-(

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@VincentHardouin VincentHardouin changed the title [TECH] Initial Dockerfile to host pix-site in scalway [TECH] Initial Dockerfile to host pix-site in scaleway May 14, 2024
@VincentHardouin VincentHardouin self-requested a review May 15, 2024 12:05
@yoandl yoandl force-pushed the scalway-hosting branch from 2c5d3c7 to 6318ffb Compare May 15, 2024 13:15
@BerengereC BerengereC dismissed VincentHardouin’s stale review May 17, 2024 13:56

Les changements ont été pris en compte

Copy link
Contributor

@yoandl yoandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pix-service-auto-merge pix-service-auto-merge merged commit 6d8fae1 into dev May 17, 2024
2 of 4 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the scalway-hosting branch May 17, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants