[FEATURE] Ne pas afficher le bandeau "vous semblez ne pas être en France" dans les DOM-TOMs (PIX-7713) #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants : Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-site-review-pr525/environment |
Co-authored-by: Rébecca Kaci <[email protected]>
clemlatz
force-pushed
the
pix-7713-hide-out-of-france-banner-in-dom-toms
branch
from
a67f80a to
9ba7758
Compare
clemlatz
added
👀 Tech Review Needed
👀 Func Review Needed
team-acces
and removed
🚧 Development in progress
labels
lego-technix
approved these changes
Apr 14, 2023
|
Je n'ai malheureusement pas pu tester fonctionnellement car je ne dispose pas d'un VPN me permettant de me géolocaliser dans un DOM-TOM. |
Co-authored-by: Rébecca Kaci <[email protected]>
clemlatz
force-pushed
the
pix-7713-hide-out-of-france-banner-in-dom-toms
branch
from
9ba7758 to
9e41a4d
Compare
igorissen
approved these changes
Apr 17, 2023
clemlatz
force-pushed
the
pix-7713-hide-out-of-france-banner-in-dom-toms
branch
from
9e41a4d to
519bade
Compare
clemlatz
added
Func Review OK
Tech Review OK
and removed
👀 Tech Review Needed
👀 Func Review Needed
labels
pix-service-auto-merge
deleted the
pix-7713-hide-out-of-france-banner-in-dom-toms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
La bannière "vous semblez ne pas être en France" est affichée pour les utilisateurs situés dans les DOM-TOM.
🤖 Proposition
Ajouter les codes pays dans les DOM-TOM en plus de celui de la France dans les exceptions à l'affichage de la bannière.
🌈 Remarques
RAS
💯 Pour tester