[BUGFIX] Répare l'environnement de dev #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbertrand
added
👀 Tech Review Needed
team-evaluation
|
I'm deploying this PR to these urls:
Please check it out! |
matthiasferraina
approved these changes
May 12, 2022
VincentHardouin
approved these changes
May 12, 2022
yannbertrand
added
Tech Review OK
🚀 Ready to Merge
and removed
👀 Tech Review Needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Depuis la montée de version de Node en 16.14.0,
npm run dev:siterenvoie des erreurs comme quoi les slices zones custom n'existent pas.🤖 Solution
Utiliser un autre nom de composant
PrismicCustomSliceZone.🌈 Remarques
Il faudrait idéalement utiliser le
SliceZonefournit par Prismic mais ça demande de mapper les slices types aux composants associés en passant un attributcomponentsau<slice-zone ... />(voir https://github.com/ngiusti/medallia-test/blob/8f59fdf93070211fba80c59f6fe07f48592d6fec/slices/index.js). Vu qu'on ajoute des attributsindex-for-iddans notreCustomSliceZone, ça a pas mal d'impacts, on ne le fait pas dans cette PR.💯 Pour tester
Vérifier que les pages sont toujours accessibles.