[TECH] Supprimer le store Vuex (PIX-1468). #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentHardouin
added
👀 Tech Review Needed
team-evaluation
VincentHardouin
force-pushed
the
tech-remove-vuex-store
branch
2 times, most recently
from
d2a5e37 to
86c04b3
Compare
VincentHardouin
changed the title
|
I'm deploying this PR to these urls:
Please check it out! |
VincentHardouin
changed the title
nlepage
approved these changes
Nov 8, 2021
Comment on lines
+57
to
+60
| this.mainFooters = await documentFetcher( | ||
| this.$prismic, | ||
| this.$i18n | ||
| ).findByType(documents.mainFooter) |
There was a problem hiding this comment.
suggestion(non bloquant): Je ne sais pas si c'est possible techniquement, est-ce qu'on pourrait faire un plugin pour injecter le documentFetcher ? Comme ça on ferait :
Suggested change
| this.mainFooters = await documentFetcher( | |
| this.$prismic, | |
| this.$i18n | |
| ).findByType(documents.mainFooter) | |
| this.mainFooters = await this.$documentFetcher.findByType(documents.mainFooter) |
cf le 1er exemple où ils injectent un $hello : https://nuxtjs.org/docs/directory-structure/plugins/
There was a problem hiding this comment.
Si j'y ai pensé, je pense le faire dans une autre PR !
pix-service-auto-merge
force-pushed
the
tech-remove-vuex-store
branch
from
86c04b3 to
37982f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Nous utilisons le store principalement pour les différents menus qui sont présents sur toutes les pages.
Comme ils sont présents sur toutes les pages, ils ont été mis directement dans le
layout. Cela avait pour conséquence qu'à l'époque Nuxt ne proposait pas de fetcher des informations depuis un composant. Cependant depuis la version 2.12 c'est devenu possible.De plus, entre temps le site est devenu statique, le store l'est aussi devenu par conséquent : Nuxt génère un fichier
state.jsque nous allons chercher dès la première requête au site. Il n'a donc aucun intérêt.🤖 Solution
🌈 Remarques
💯 Pour tester