-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Ajouter un état actif au éléments de la navigation (PIX-2235). #275
Merged
pix-service-auto-merge
merged 3 commits into
dev
from
pix-2235-add-active-style-to-dropdown
Jun 16, 2021
Merged
[FEATURE] Ajouter un état actif au éléments de la navigation (PIX-2235). #275
pix-service-auto-merge
merged 3 commits into
dev
from
pix-2235-add-active-style-to-dropdown
Jun 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomasevano
added
👀 Tech Review Needed
👀 Func Review Needed
team-evaluation
PR relatives à l'expérience d'évaluation
labels
Jun 14, 2021
I'm deploying this PR to these urls:
Please check it out! |
MelanieMEB
reviewed
Jun 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK !
Je valide dès que coté CSS, on a aussi le souligné :)
MelanieMEB
force-pushed
the
pix-2235-add-active-style-to-dropdown
branch
from
June 14, 2021 12:17
d588520
to
77f0f52
Compare
celineung
force-pushed
the
pix-2235-add-active-style-to-dropdown
branch
from
June 14, 2021 14:12
77f0f52
to
e1ee29c
Compare
celineung
changed the title
[TECH] Ajouter un état actif au label de la nav (PIX-2235)
[FEATURE] Ajouter un état actif au éléments de la navigation (PIX-2235).
Jun 14, 2021
celineung
force-pushed
the
pix-2235-add-active-style-to-dropdown
branch
2 times, most recently
from
June 14, 2021 15:49
cd1c682
to
01857b9
Compare
alexandrecoin
force-pushed
the
pix-2235-add-active-style-to-dropdown
branch
from
June 15, 2021 09:31
01857b9
to
91957e8
Compare
alexandrecoin
approved these changes
Jun 15, 2021
celineung
approved these changes
Jun 15, 2021
MelanieMEB
approved these changes
Jun 16, 2021
MelanieMEB
added
🚀 Ready to Merge
Tech Review OK
and removed
👀 Func Review Needed
👀 Tech Review Needed
labels
Jun 16, 2021
pix-service-auto-merge
force-pushed
the
pix-2235-add-active-style-to-dropdown
branch
from
June 16, 2021 08:39
91957e8
to
4df7e04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Les éléments "Accueil" et dropdowns de la navigation n'ont pas l'état active lorsque l'on est sur la page.
🤖 Solution
🌈 Remarques
💯 Pour tester
Se rendre sur pix-site et naviguer sur les différentes pages.