Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Ajouter un état actif au éléments de la navigation (PIX-2235). #275

Merged
merged 3 commits into from
Jun 16, 2021

Conversation

Thomasevano
Copy link
Contributor

@Thomasevano Thomasevano commented Jun 14, 2021

🦄 Problème

Les éléments "Accueil" et dropdowns de la navigation n'ont pas l'état active lorsque l'on est sur la page.

🤖 Solution

  • Modifier le composant PixLink pour que l'on détecte que l'on est sur un chemin relatif lorsque l'on se trouve sur la page d'acceuil
  • Ajouter une class au bouton dropdown lorsque l'on est sur une page enfant.

🌈 Remarques

💯 Pour tester

Se rendre sur pix-site et naviguer sur les différentes pages.

@pix-service
Copy link

I'm deploying this PR to these urls:

Please check it out!

Copy link
Member

@MelanieMEB MelanieMEB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK !
Je valide dès que coté CSS, on a aussi le souligné :)

components/slices/NavigationZone.vue Outdated Show resolved Hide resolved
@MelanieMEB MelanieMEB force-pushed the pix-2235-add-active-style-to-dropdown branch from d588520 to 77f0f52 Compare June 14, 2021 12:17
@celineung celineung force-pushed the pix-2235-add-active-style-to-dropdown branch from 77f0f52 to e1ee29c Compare June 14, 2021 14:12
@celineung celineung marked this pull request as ready for review June 14, 2021 15:05
@celineung celineung changed the title [TECH] Ajouter un état actif au label de la nav (PIX-2235) [FEATURE] Ajouter un état actif au éléments de la navigation (PIX-2235). Jun 14, 2021
@celineung celineung force-pushed the pix-2235-add-active-style-to-dropdown branch 2 times, most recently from cd1c682 to 01857b9 Compare June 14, 2021 15:49
@alexandrecoin alexandrecoin force-pushed the pix-2235-add-active-style-to-dropdown branch from 01857b9 to 91957e8 Compare June 15, 2021 09:31
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-2235-add-active-style-to-dropdown branch from 91957e8 to 4df7e04 Compare June 16, 2021 08:39
@pix-service-auto-merge pix-service-auto-merge deleted the pix-2235-add-active-style-to-dropdown branch June 16, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Ready to Merge team-evaluation PR relatives à l'expérience d'évaluation Tech Review OK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants