Activer l'asset-extractor et corriger l'affichage d'image sur pix.org #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm deploying this PR to these urls:
Please check it out! |
bpetetot
changed the title
HEYGUL
approved these changes
Mar 4, 2021
MelanieMEB
approved these changes
Mar 4, 2021
bpetetot
added
Func Review OK
Tech Review OK
🚀 Ready to Merge
and removed
👀 Func Review Needed
👀 Tech Review Needed
labels
pix-service-auto-merge
force-pushed
the
add-assets-extractor
branch
from
49e52de to
d0f375e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Les URL
https://pix.org/_assetscontenant les images extraites dans le bundle sont automatiquement réécrites via la configuration nginx enhttps://pix.org/fr/_assets(ajout de la langue)🤖 Solution
Ajouter une exception sur
_assetsdans les réécriture d'URL de la configurationnginx🌈 Remarques
💯 Pour tester
Aller sur https://site-pr250.review.pix.org et vérifier que les images s'affichent.