[BUILD] Add build module to extract assets (images, videos, pdf) in final bundle #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm deploying this PR to these urls:
Please check it out! |
bpetetot
force-pushed
the
feature-replace-remote-assets
branch
from
f47eafa to
0335118
Compare
HEYGUL
force-pushed
the
feature-replace-remote-assets
branch
from
0335118 to
63ca190
Compare
HEYGUL
force-pushed
the
feature-replace-remote-assets
branch
2 times, most recently
from
4ec5b09 to
b2f2ed6
Compare
HEYGUL
approved these changes
Feb 17, 2021
Anne-Gaelle-S
approved these changes
Feb 17, 2021
VincentHardouin
approved these changes
Feb 17, 2021
bpetetot
added
Func Review OK
Tech Review OK
and removed
👀 Func Review Needed
👀 Tech Review Needed
labels
bpetetot
force-pushed
the
feature-replace-remote-assets
branch
from
b2f2ed6 to
9d142de
Compare
bpetetot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Les assets (images, vidéos, etc) sont actuellement servies depuis prismic.
Mensuellement on dépasse le quota de bande passante inclus dans notre forfait.
Autre conséquence, nous ne profitons pas du CDN de Baleen.
🤖 Solution
Création d'un module de build nuxt permettant d'extraire les assets (dont l'extension est configurable) servies depuis différentes url (configurables via
hostnames) dans le bundle final.🌈 Remarques
Ce module est un bon candidat pour être open source dans son propre repo et ainsi partagé à la communauté Nuxt.
On a également extrait la vidéo (67 Mo !) depuis ovh.
Il faudrait envisager de la compresser pour soulager la bande passante de nos utilisateurs.
💯 Pour tester
Se connecter à la review app.
Vérifier que les images servies le sont depuis l'adresse de la review app et qu'aucun appel à prismic n'est fait.