Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Implémentation de la nouvelle barre de navigation (PIX-1071). #166

Merged
merged 18 commits into from
Sep 25, 2020
Merged

[FEATURE] Implémentation de la nouvelle barre de navigation (PIX-1071). #166

merged 18 commits into from
Sep 25, 2020

Conversation

alexandrecoin
Copy link
Contributor

@alexandrecoin alexandrecoin commented Sep 15, 2020 •
edited by celineung
Loading

🦄 Problème

Le site vitrine change de peau, donc la barre de navigation en haut doit faire peau neuve.

Attendu :

https://app.abstract.com/projects/c43b8749-ba3a-474e-a6c5-dbf76bade2ee/branches/0f98f94c-8f44-4d4f-a988-72be104570aa/commits/latest/files/7CDCEB46-2B82-4218-B719-A559D817B735/layers/22F59764-AE99-4E92-8376-001C80AC08CF?collectionId=92047f7c-2ee2-4adc-9227-9b63f56bf55a&collectionLayerId=d4e6d1eb-18e3-452c-baf3-158576a9acfd

🤖 Solution

  • Remplacement des items de navigation de l'ancienne nav par les nouveaux provenant de Prismic
  • Ajout d'une dropdown de sélection des éléments de sous-navigation.

🌈 Remarques

  • complication pour détecter si le bouton de la dropdown doit avoir le style actif: vu avec Quentin pour ne mettre le style actif que sur la sous-navigation et pas le bouton dropdown parent
  • ajout d'un attribut dropdown-index pour défférencier les dropdowns et avoir les dropdown indépendants les uns des autres
  • Vu la nav avec Quentin, globalement OK mais shadow de la nav à revoir (pas bloquant, ça peut faire l'objet d'un prochain ticket si celui-ci est mergé)

✨ Review App

https://pix-site-review-pr166.osc-fr1.scalingo.io

@celineung celineung force-pushed the pix-1071-new-navigation branch from aaab1e7 to d988a7b Compare September 16, 2020 09:57
@celineung celineung force-pushed the pix-1071-new-navigation branch 7 times, most recently from 8bf799e to 4b27912 Compare September 16, 2020 16:58
@celineung celineung marked this pull request as ready for review September 16, 2020 17:04
@celineung celineung force-pushed the pix-1071-new-navigation branch 2 times, most recently from 10bd7ed to 193dd53 Compare September 16, 2020 17:07
@celineung celineung force-pushed the pix-1071-new-navigation branch 5 times, most recently from 5761ea8 to e89484a Compare September 17, 2020 10:41
MelanieMEB
MelanieMEB reviewed Sep 21, 2020
View reviewed changes
Copy link
Member

@MelanieMEB MelanieMEB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposition d'amélioration. Sinon ça me parait bien. A tester sous IE avec Phili

components/slices/NavigationZone.vue Outdated Show resolved Hide resolved
@celineung celineung force-pushed the pix-1071-new-navigation branch from e89484a to 609cb65 Compare September 21, 2020 09:25
@celineung celineung force-pushed the pix-1071-new-navigation branch 2 times, most recently from 7c76b26 to c840982 Compare September 21, 2020 12:29
@celineung celineung force-pushed the pix-1071-new-navigation branch from 6da4908 to 3922c6d Compare September 23, 2020 09:15
@celineung
Copy link
Contributor

Problème de sous-menu sous IE : Impossible de cliquer sur Enseignement Sup. Je pense que le clic pour sortir est pris au dessus du clic pour le lien.

c'est fixé =)

@celineung celineung closed this Sep 23, 2020
@celineung celineung reopened this Sep 23, 2020
@celineung celineung force-pushed the pix-1071-new-navigation branch from 3922c6d to 01a2f8d Compare September 23, 2020 10:34
MelanieMEB
MelanieMEB approved these changes Sep 24, 2020
View reviewed changes
components/BurgerMenuNav.vue Outdated Show resolved Hide resolved
alexandrecoin and others added 3 commits September 25, 2020 10:04
@alexandrecoin @celineung
Create navigation logo zone
1688f4d
@jonasgrilleres @celineung
Filter old navigation
9f067e1 
Remove old navigation header display
Keep navigation items because used in page footer
@alexandrecoin @celineung
Display logos zone in header
14c0590
@celineung celineung force-pushed the pix-1071-new-navigation branch from 01a2f8d to 124e9af Compare September 25, 2020 08:06
alexandrecoin and others added 15 commits September 25, 2020 10:08
@celineung celineung force-pushed the pix-1071-new-navigation branch from 124e9af to f83eb13 Compare September 25, 2020 08:08
@celineung celineung merged commit 39c006f into dev Sep 25, 2020
@celineung celineung deleted the pix-1071-new-navigation branch September 25, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celineung celineung celineung left review comments

@MelanieMEB MelanieMEB MelanieMEB approved these changes

@sbedeau sbedeau Awaiting requested review from sbedeau

Assignees

@celineung celineung

@alexandrecoin alexandrecoin

Labels
👀 Func Review Needed 👀 Tech Review Needed team-evaluation PR relatives à l'expérience d'évaluation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexandrecoin @celineung @sbedeau @MelanieMEB @jonasgrilleres