Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate Variables default usage #1

Open
darpham opened this issue Feb 28, 2021 · 1 comment
Open

Evaluate Variables default usage #1

darpham opened this issue Feb 28, 2021 · 1 comment

Comments

@darpham
Copy link
Contributor

darpham commented Feb 28, 2021

Evaluate each variable with a default flag set.
Do we want a default value for that specific variable.
Do we want to add a default value for a variable that doesn't have one already.

Use examples folder as the guiding light.
Make a PR explaining each change made.

Command to show all default variables in bash.

 grep -r 'default.*=' . --exclude-dir=.terraform --exclude-dir=example --exclude=README.md
 
./main.tf:  default_alb_url = var.default_alb_url
./applicationlb/variables.tf:  default = { terraform_managed = "true" }
./service-external-api/variables.tf:  default = "us-east-2"
./service-external-api/variables.tf:  default = { terraform_managed = "true" }
./service-external-api/variables.tf:  default     = "/"
./service-external-api/variables.tf:  default = 1
./service-external-api/variables.tf:  default = 256
./service-external-api/variables.tf:  default = 0
./service-external-api/variables.tf:  default = 0
./bastion/variables.tf:  default = { terraform_managed = "true" }
./bastion/variables.tf:  default     = "t2.micro"
./bastion/variables.tf:  default     = ""
./bastion/variables.tf:  default = "ubuntu"
./bastion/variables.tf:  default = {
./bastion/variables.tf:  default = "false"
./bastion/variables.tf:  default     = "5,0,*,* * * * *"
./bastion/variables.tf:  default = ""
./network/variables.tf:  default = "10.10.0.0/16"
./network/variables.tf:  default = { terraform_managed = "true" }
./service-internal-api/variables.tf:  default = "us-east-2"
./service-internal-api/variables.tf:  default = { terraform_managed = "true" }
./service-internal-api/variables.tf:  default     = "/"
./service-internal-api/variables.tf:  default = 1
./service-internal-api/variables.tf:  default = 256
./service-internal-api/variables.tf:  default = 0
./service-internal-api/variables.tf:  default = 0
./ecs/variables.tf:  default = "10.1.0.0/16"
./ecs/variables.tf:  default = 0
./ecs/variables.tf:  default = "t3.small"
./ecs/variables.tf:  default = { terraform_managed = "true" }
./github_action/variables.tf:  default = { terraform_managed = "true" }
./variables.tf:  default = { terraform_managed = "true" }
./variables.tf:  default     = "bastion.foodoasis.net"
./variables.tf:  default     = "10.10.0.0/16"
./variables.tf:  default = 1
./variables.tf://   default = 256
./variables.tf://   default = 512
./variables.tf://   default = "/health"
./variables.tf://   default     = "latest"
./variables.tf://   default = 1
./variables.tf:  default     = ""
./variables.tf:  default     = "t2.micro"
./variables.tf:  default     = "5,0,*,* * * * *"
./variables.tf:  default = {
./service-client/variables.tf:  default = { terraform_managed = "true" }
./service-client/variables.tf:  default = "/"
./service-client/variables.tf:  default = 1
./service-client/variables.tf:  default = 0
./service-client/variables.tf:  default = 0
./service-client/variables.tf:  default = 80
./rds/variables.tf:  default = { terraform_managed = "true" }
./rds/variables.tf:  default     = "db.t3.medium"
./rds/variables.tf:  default     = "11.10"
./rds/variables.tf:  default = true
./rds/variables.tf:  default = "11"
./rds/variables.tf:  default     = ""
./acm/variables.tf:  default = { terraform_managed = "true" }
@jafow
Copy link
Contributor

jafow commented Feb 28, 2021

Looking good. Defaults should be reasonable and enough to get something running. think these are all fine defaults. Here are some that you might consider changing:
postgres 12 would be a good default engine because it's out and stable a long time now. May as well default to the latest stable.

Tasks cpu memory and ram should not use default 0 because if someone using the module does not set them their app will likely not start and that could complicate debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants