Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Tracking: Press Section #426

Closed
5 tasks done
superbunker opened this issue Aug 26, 2021 · 18 comments
Closed
5 tasks done

Bug Tracking: Press Section #426

superbunker opened this issue Aug 26, 2021 · 18 comments
Assignees
Labels
bug Something isn't working p-feature: Press Anything to do with the Press page role: front end size: 1pt 1 points = 6 hours of work or less

Comments

@superbunker
Copy link
Contributor

superbunker commented Aug 26, 2021

Overview

We need to define the problems with the Press page on the site so that we can fix or delay the fixes until after MVP

Action Items

  • In a comment below: Identify a bug
    • provide a screen shot of problem
    • details on how to replicate
    • provide any appropriate links that would be useful.
  • Product/development will review the bugs, combine related coding into new issues and determine prioritization for them.

Resources

Bug Priority Code:

@superbunker superbunker mentioned this issue Aug 26, 2021
10 tasks
@superbunker superbunker added the bug Something isn't working label Aug 26, 2021
@superbunker superbunker added this to the 6 - Launch MVP milestone Aug 26, 2021
@superbunker

This comment has been minimized.

@superbunker

This comment has been minimized.

@ExperimentsInHonesty

This comment has been minimized.

@ExperimentsInHonesty

This comment has been minimized.

@ExperimentsInHonesty

This comment has been minimized.

@ExperimentsInHonesty

This comment has been minimized.

@ExperimentsInHonesty
Copy link
Member

I have issues with the slider at the bottom, but until we have a new designer on the site, I am just putting a pin in it, so that we can discuss our options then.

@ExperimentsInHonesty

This comment has been minimized.

@susantangux
Copy link

"Press" desktop and mobile webpage images exported from Figma. Please compare live site to these Figma image files:
Press Kit_Desktop
Press Kit_Mobile

@nahyungkim1220
Copy link
Contributor

nahyungkim1220 commented Aug 31, 2021

Thank you for the Figma images, Susan!

One thing I noticed is the button count isn't matching on pc (chrome, windows 10). Wondering if this was intentional to exclude LinkedIn from our socials?

Figma
image

Live Page
image

@nahyungkim1220
Copy link
Contributor

nahyungkim1220 commented Aug 31, 2021

Apologies! accidentally clicked the "Close with comment" button.

Buttons and words overlap when the browser is minimized (chrome, windows 10).

image

@nahyungkim1220

This comment has been minimized.

@nahyungkim1220
Copy link
Contributor

nahyungkim1220 commented Aug 31, 2021

Image sizes on PC don't match Figma.

Figma
image

Live Page

@nahyungkim1220
Copy link
Contributor

nahyungkim1220 commented Aug 31, 2021

Image size changes depending on the button in PC. (Wondering if it's intentional to match the post formatting on different socials?)

Figma
image


Live Page
Facebook

Twitter (slightly narrower and wider than Facebook, change is more visible on live page)

Instagram

@nahyungkim1220

This comment has been minimized.

@nahyungkim1220

This comment has been minimized.

@henlatourrette henlatourrette added p-feature: Press Anything to do with the Press page and removed feature: missing missing a feature label labels Aug 31, 2021
@henlatourrette
Copy link
Member

Image size changes depending on the button in PC. (Wondering if it's intentional to match the post formatting on different socials?)

Figma image Live Page Facebook

Twitter (slightly narrower and wider than Facebook, change is more visible on live page)

Instagram

This was intentionally since different social media platforms have different image sizes for their posts.

@henlatourrette
Copy link
Member

Since most bugs were already considered in issue #433, I propose closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p-feature: Press Anything to do with the Press page role: front end size: 1pt 1 points = 6 hours of work or less
Development

No branches or pull requests

7 participants