add: SDK coretypes #1253
Closed
add: SDK coretypes #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
eightfilms
reviewed
Feb 19, 2024
Co-authored-by: bing <[email protected]>
| #[derive(Archive, Deserialize, Serialize, PartialEq, Eq, Default, Copy, Clone)] | ||
| #[archive(compare(PartialEq))] | ||
| #[archive_attr(derive(Debug))] | ||
| pub struct Poseidon2HashType([u8; 4]); |
There was a problem hiding this comment.
This seems suspicious. Our hash digest surely is longer than 8 * 4 = 32 bits?
There was a problem hiding this comment.
Will fix it when we actually make use of it. I treat it as a placeholder for now
There was a problem hiding this comment.
Plus Poseidon2Hash for us can be different depending on params?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds commonly used coretypes for further use in SDK.