Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Fix Postman #74

Merged
merged 3 commits into from
Apr 13, 2022
Merged

Fix Postman #74

merged 3 commits into from
Apr 13, 2022

Conversation

badurinantun
Copy link
Contributor

@badurinantun badurinantun commented Apr 11, 2022 •
edited
Loading

Usage changes

  • changed L1 message to have all snake cases
  • fixed KeyError issue

Dev changes

  • Added flush response tests
  • Updated MockMessaging artifact
  • Add tests for flush response

@badurinantun badurinantun self-assigned this Apr 11, 2022
@badurinantun badurinantun changed the title Update MockStarkneMessaging.json Fix Postman Apr 12, 2022
FabijanC
FabijanC suggested changes Apr 12, 2022
View reviewed changes
test/test_postman.py Outdated Show resolved Hide resolved
@JorikSchellekens
Copy link
Contributor

JorikSchellekens commented Apr 12, 2022 •
edited
Loading

It looks like the case of the MockStarknetMessaging contract was changed a short while ago in this pr. However, the events used in starknet use snake case. I think the correct solution is to revert the MockStarknetMessaging contract.

Just found the case change in the tests from cairo-lang

@FabijanC FabijanC merged commit 014cd96 into master Apr 13, 2022
@FabijanC FabijanC deleted the fix-postman branch April 13, 2022 08:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FabijanC FabijanC Awaiting requested review from FabijanC

Assignees

@badurinantun badurinantun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@badurinantun @JorikSchellekens @FabijanC