Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default request limit #649

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Remove default request limit #649

merged 1 commit into from
Nov 21, 2024

Conversation

marioiordanov
Copy link
Contributor

@marioiordanov marioiordanov commented Nov 20, 2024

Why this change is needed

User on telegram reported that after setting --request-body-size-limit to big enough number his requests were being rejected.

Development related changes

Until this moment there were 2 limits on requests. 1 default by axum which is 2MB and 1 custom specified by --request-body-size-limit. Axum's default limit is disabled.

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
    • Once you make the PR reviewable, please avoid force-pushing
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

@marioiordanov marioiordanov merged commit 3657a01 into main Nov 21, 2024
1 check passed
@marioiordanov marioiordanov deleted the request-limit branch November 21, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants