Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay 3.0 launch until December 2 #72

Closed
abandeali1 opened this issue Nov 15, 2019 · 0 comments
Closed

Delay 3.0 launch until December 2 #72

abandeali1 opened this issue Nov 15, 2019 · 0 comments
Labels
status: implemented Proposed changes have been implemented (and deployed, if smart contract) type: operations

Comments

@abandeali1
Copy link
Member

Summary

2 minor issues were discovered by the 0x team in the 14 day grace period leading up to the 3.0 launch (as outlined below). Given that the mainnet contract configurations are not yet live, we recommend redeploying the 3.0 contracts and and resubmitting their configurations to the ZeroExGovernor, restarting the 14 day grace period.

  1. Rounding in the wrong direction in marketBuyOrdersNoThrow causes a high failure rate in marketBuyOrdersFillOrKill. Note that this bug also exists in the 2.0 contracts, but it only really becomes problematic in the new fillOrKill counterpart. We expect marketBuyOrdersFillOrKill to be one of the most used functions within the Exchange contract, so it is important that this is patched. This issue has been fixed here.

  2. An off by one error led to staking pool operators only being able to specify a maximum operator share of 99.9999%. This issue has been fixed here.

Motivation

Delaying the upgrade now minimizes any future migration overhead. This will also give developers an extra week to prepare for the migration.

@dekz dekz pinned this issue Nov 19, 2019
@mintcloud mintcloud unpinned this issue Feb 27, 2020
@mintcloud mintcloud added status: implemented Proposed changes have been implemented (and deployed, if smart contract) type: operations labels Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: implemented Proposed changes have been implemented (and deployed, if smart contract) type: operations
Projects
None yet
Development

No branches or pull requests

2 participants