Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Add deployedBytecode to contract-artifacts #2173

Closed
xianny opened this issue Sep 18, 2019 · 2 comments
Closed

Add deployedBytecode to contract-artifacts #2173

xianny opened this issue Sep 18, 2019 · 2 comments

Comments

@xianny
Copy link
Contributor

xianny commented Sep 18, 2019

In #2108 we added the ability to use a local EVM to execute pure Solidity functions in @0x/abi-gen-wrappers, e.g. in DevUtilsContract, ExchangeContract, etc.

However, it's dependent on an eth call to eth_getCode.

We would like to use pure methods in DevUtilsContract to replace @0x/order-utils. At the moment, using DevUtilsContract introduces a dependency on RPC calls, ganache tooling (in tests), whereas @0x/order-utils only uses local typescript code.

Adding deployedBytecode to @0x/contract-artifacts will enable devs to execute the pure Solidity functions without any external calls.

@fabioberger
Copy link
Contributor

@xianny isn't another part of this issue actually using the deployedBytecode or do we have a separate issue for that?

@xianny
Copy link
Contributor Author

xianny commented Oct 1, 2019

Yup! There's a separate PR to use the deployed bytecode and it's merged here: #2198

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants