Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Upgrade Python tools for v3 #2163

Closed
feuGeneA opened this issue Sep 16, 2019 · 1 comment · Fixed by #2284
Closed

Upgrade Python tools for v3 #2163

feuGeneA opened this issue Sep 16, 2019 · 1 comment · Fixed by #2284
Assignees
Labels

Comments

@feuGeneA
Copy link
Contributor

  • contract_wrappers.py

    • re-generate, update type aliases (eg Order class mapping to 0xdeadbeef... class tuple representation) ensure functionality of json schema validation
    • adapt code examples and tests
  • sra_client.py

    • adapt code examples (there end-to-end tests of post, retrieve, fill, cancel)
  • order_utils.py

    • either replace utils (order hashing, asset data codec, etc) with pure EVM calls to the DevUtils contract, or adapt the existing implementations
@feuGeneA feuGeneA self-assigned this Sep 16, 2019
@stale
Copy link

stale bot commented Oct 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 16, 2019
@feuGeneA feuGeneA removed the stale label Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant