Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

OrderValidator -> DevUtils #1909

Closed
4 of 6 tasks
xianny opened this issue Jun 28, 2019 · 4 comments
Closed
4 of 6 tasks

OrderValidator -> DevUtils #1909

xianny opened this issue Jun 28, 2019 · 4 comments

Comments

@xianny
Copy link
Contributor

xianny commented Jun 28, 2019

OrderValidator is now OrderValidationUtils, which is inherited by DevUtils (among many other useful functions). We should replace OrderValidator with DevUtils in abi-gen-wrappers, contract-artifacts, and anywhere else it might be lingering.

Motivation: Solidity source code for OrderValidator has already been deleted and it won't be redeployed for V3. It currently exists only on the chain and as compiler output in contract-artifacts, which makes it hard to debug or develop on.

  • Compile DevUtils and add the artifact to contract-artifacts
  • Run migration script to deploy only DevUtils
  • Add deployed address to contract-addresses
  • Generate DevUtils wrapper in abi-gen-wrappers
  • replace uses of OrderValidator throughout monorepo with DevUtils
  • Remove OrderValidator from contract-addresses, contract-artifacts, and abi-gen-wrappers`
@xianny xianny self-assigned this Jun 28, 2019
@xianny xianny added this to the v3 development milestone Jul 16, 2019
@xianny
Copy link
Contributor Author

xianny commented Aug 15, 2019

@dekz @feuGeneA can I close this? Looks like you took care of it :)

@feuGeneA
Copy link
Contributor

I'll let @dekz provide the authoritative answer, but it looks to me like we did everything except replacing uses of OrderValidator.

@stale
Copy link

stale bot commented Sep 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 14, 2019
@stale
Copy link

stale bot commented Oct 14, 2019

This issue has been automatically closed because no activity occured in 7 days after being marked as stale. If it's still relevant - feel free to reopen. Thank you for your contributions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants