Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

isValidSignatureAsync does not normalize addresses #1095

Closed
IncentiveLoop opened this issue Sep 27, 2018 · 2 comments · Fixed by #1096
Closed

isValidSignatureAsync does not normalize addresses #1095

IncentiveLoop opened this issue Sep 27, 2018 · 2 comments · Fixed by #1096
Assignees
@fabioberger

Comments

@IncentiveLoop
Copy link

When signing an order using ecSignOrderHashAsync the signer address is normalized, however when attempting to recover the signer using isValidSignatureAsync the address is not normalized.

This can lead to invalid address recovery, it would be great if addresses were normalized in isValidSignatureAsync too.
@fabioberger fabioberger self-assigned this Sep 27, 2018
@fabioberger fabioberger mentioned this issue Sep 27, 2018
Merged
5 tasks
@fabioberger
Copy link
Contributor

Thanks for the report @IncentiveLoop! Fix will go out in the next package release!

@fabioberger
Copy link
Contributor

Released: https://github.com/0xProject/0x-monorepo/releases/tag/monorepo%40ac14dd2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fabioberger fabioberger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add address normalization to isValidECSignature method 0xProject/0x-monorepo
2 participants
@fabioberger @IncentiveLoop