From 9192a2a121439d85201ca2edb16563ea2e18e799 Mon Sep 17 00:00:00 2001 From: Lawrence Forman Date: Wed, 4 Sep 2019 14:54:50 -0400 Subject: [PATCH] `@0x/contracts-staking`: Keep fees not associated with a pool. --- contracts/staking/contracts/src/fees/MixinExchangeFees.sol | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/contracts/staking/contracts/src/fees/MixinExchangeFees.sol b/contracts/staking/contracts/src/fees/MixinExchangeFees.sol index cdae7bce7d..940f5f9edf 100644 --- a/contracts/staking/contracts/src/fees/MixinExchangeFees.sol +++ b/contracts/staking/contracts/src/fees/MixinExchangeFees.sol @@ -97,15 +97,12 @@ contract MixinExchangeFees is // There is a pool associated with `makerAddress`. // TODO(dorothy-zbornak): When we have epoch locks on delegating, we could // preclude pools that have no delegated stake, since they will never have - // stake in this epoch. + // stake in this epoch and are therefore not entitled to rewards. uint256 _feesCollectedThisEpoch = protocolFeesThisEpochByPool[poolId]; protocolFeesThisEpochByPool[poolId] = _feesCollectedThisEpoch.safeAdd(amount); if (_feesCollectedThisEpoch == 0) { activePoolsThisEpoch.push(poolId); } - } else { - // No pool associated with `makerAddress`. Refund the fee. - msg.sender.transfer(amount); } }