From 047a84271906282916aa3c8c70ea2c47e7ff1202 Mon Sep 17 00:00:00 2001 From: Amir Bandeali Date: Wed, 2 Jan 2019 17:05:32 -0800 Subject: [PATCH] FIx linting errors --- contracts/protocol/test/exchange/core.ts | 1 - contracts/tokens/src/artifacts/index.ts | 1 + packages/pipeline/src/parsers/events/exchange_events.ts | 2 ++ packages/pipeline/src/parsers/sra_orders/index.ts | 2 ++ .../pipeline/src/utils/transformers/asset_proxy_id_types.ts | 4 ++++ 5 files changed, 9 insertions(+), 1 deletion(-) diff --git a/contracts/protocol/test/exchange/core.ts b/contracts/protocol/test/exchange/core.ts index 8367898de8..42db8623dd 100644 --- a/contracts/protocol/test/exchange/core.ts +++ b/contracts/protocol/test/exchange/core.ts @@ -1,4 +1,3 @@ -import { artifacts as interfacesArtifacts, IAssetDataContract } from '@0x/contracts-interfaces'; import { chaiSetup, constants, diff --git a/contracts/tokens/src/artifacts/index.ts b/contracts/tokens/src/artifacts/index.ts index 63b808748c..977d01c3eb 100644 --- a/contracts/tokens/src/artifacts/index.ts +++ b/contracts/tokens/src/artifacts/index.ts @@ -22,6 +22,7 @@ import * as UnlimitedAllowanceToken_v1 from '../../generated-artifacts/Unlimited import * as WETH9 from '../../generated-artifacts/WETH9.json'; import * as ZRXToken from '../../generated-artifacts/ZRXToken.json'; +// tslint:disable:no-unnecessary-type-assertion export const artifacts = { DummyERC20Token: DummyERC20Token as ContractArtifact, DummyMultipleReturnERC20Token: DummyMultipleReturnERC20Token as ContractArtifact, diff --git a/packages/pipeline/src/parsers/events/exchange_events.ts b/packages/pipeline/src/parsers/events/exchange_events.ts index 50fad7e001..8d2e7dec7d 100644 --- a/packages/pipeline/src/parsers/events/exchange_events.ts +++ b/packages/pipeline/src/parsers/events/exchange_events.ts @@ -7,6 +7,8 @@ import * as R from 'ramda'; import { ExchangeCancelEvent, ExchangeCancelUpToEvent, ExchangeFillEvent } from '../../entities'; import { bigNumbertoStringOrNull, convertAssetProxyIdToType } from '../../utils'; +// tslint:disable:no-unnecessary-type-assertion + /** * Parses raw event logs for a fill event and returns an array of * ExchangeFillEvent entities. diff --git a/packages/pipeline/src/parsers/sra_orders/index.ts b/packages/pipeline/src/parsers/sra_orders/index.ts index 663b8f5095..10546921d4 100644 --- a/packages/pipeline/src/parsers/sra_orders/index.ts +++ b/packages/pipeline/src/parsers/sra_orders/index.ts @@ -6,6 +6,8 @@ import * as R from 'ramda'; import { SraOrder } from '../../entities'; import { bigNumbertoStringOrNull, convertAssetProxyIdToType } from '../../utils'; +// tslint:disable:no-unnecessary-type-assertion + /** * Parses a raw order response from an SRA endpoint and returns an array of * SraOrder entities. diff --git a/packages/pipeline/src/utils/transformers/asset_proxy_id_types.ts b/packages/pipeline/src/utils/transformers/asset_proxy_id_types.ts index bc83ad2835..ffeaaca523 100644 --- a/packages/pipeline/src/utils/transformers/asset_proxy_id_types.ts +++ b/packages/pipeline/src/utils/transformers/asset_proxy_id_types.ts @@ -2,6 +2,10 @@ import { AssetProxyId } from '@0x/types'; import { AssetType } from '../../types'; +/** + * Converts an assetProxyId to its string equivalent + * @param assetProxyId Id of AssetProxy + */ export function convertAssetProxyIdToType(assetProxyId: AssetProxyId): AssetType { switch (assetProxyId) { case AssetProxyId.ERC20: